Side navigation
#14543 closed feature (invalid)
Opened November 14, 2013 02:11PM UTC
Closed November 29, 2013 09:16AM UTC
Move more types constants to separate variables like strundefined
| Reported by: | FarSeeing | Owned by: | FarSeeing |
|---|---|---|---|
| Priority: | undecided | Milestone: | None |
| Component: | unfiled | Version: | 2.1.0-beta1 |
| Keywords: | Cc: | ||
| Blocked by: | Blocking: |
Description
As
typeof undefinedis stored in
strundefinedwhy not also store other types?
E. g.
"object"constant is used 17 times in 10 different files as per commit 203569562414304aabec22fd20b0cb17ad34c7ad
Attachments (0)
Change History (2)
Changed November 14, 2013 06:05PM UTC by comment:1
| owner: | → FarSeeing |
|---|---|
| status: | new → pending |
Changed November 29, 2013 09:16AM UTC by comment:2
| resolution: | → invalid |
|---|---|
| status: | pending → closed |
Because we get so many tickets, we often need to return them to the initial reporter for more information. If that person does not reply within 14 days, the ticket will automatically be closed, and that has happened in this case. If you still are interested in pursuing this issue, feel free to add a comment with the requested information and we will be happy to reopen the ticket if it is still valid. Thanks!
strundefinedwas introduced to work around a minification issue with UglifyJS that replacedtypeof el.domMethod !== "undefined"withe.domMethod!==void 0, which breaks in IE whenelis an XML node (see #13315). The issue has since been fixed, so it's worth looking at the effects on output size of comparingtypeofoutput to variables or constants for all cases. Would you like to tackle this, [ticket:14543 FarSeeing]?