Bug Tracker

#14488 closed feature (migrated)

Opened October 26, 2013 07:13PM UTC

Closed October 21, 2014 12:23AM UTC

Add Vagrant Support

Reported by: eric@eamann.com Owned by:
Priority: high Milestone: None
Component: build Version: 1.10.2
Keywords: Cc:
Blocked by: Blocking:
Description

The current unit test instructions advise developers to install some variant of *AMP, which is a heavy install to set up their development environment. Adding a Vagrantfile and related configuration would allow the project to ship a portable server configuration along with the code, lowering the bar new developers have to clear in order to run and contribute to unit testing.

An example Vagrantfile is available in this pull request: https://github.com/jquery/jquery/pull/1410

Attachments (0)
Change History (7)

Changed October 27, 2013 01:51AM UTC by gibson042 comment:1

The instructions also mention mongoose as an alternative to *AMP, which works fine without changing the repository (it's what I use for the same reasons mentioned here) and is already more lightweight than Vagrant.

Changed October 27, 2013 04:53PM UTC by gnarf comment:2

status: new → open

I actually like the idea of having a Vagrantfile available to spawn up an nginx that runs the same config as the builds.jenkins.jquery.com

Couple of suggestions

I could setup a dns entry for something like vagrant.jquery.com rather than needing anyone to ever edit their hosts file.

Also, posted here are the exact ways the build server for jenkins sets up its virtualhost.

# Support POST to static files - jQuery Core Unit Tests
error_page 405 =200 @405;
location @405 {
    proxy_method GET;
    proxy_pass http://localhost;
    proxy_set_header Host builds.jenkins.jquery.com;
}

# Support this funky url for jsonp.php - jQuery Core Unit Tests
rewrite ^(.*)data/jsonp.php.*$ $1data/jsonp.php;

Changed October 27, 2013 04:59PM UTC by eric@eamann.com comment:3

Replying to [comment:2 gnarf]:

I could setup a dns entry for something like vagrant.jquery.com rather than needing anyone to ever edit their hosts file.

That would be optimal, and a much better solution than ever asking anyone to edit their hosts file.

I'm also considering packaging a Vagrant box with PHP/Nginx already installed _and_ configured. This would allow the bundled configuration to ship with nothing more than a Vagrantfile (much cleaner in the repository) and developers could continue to use either their *AMP install or Mongoose instead of Vagrant without much trouble.

Changed October 28, 2013 03:26AM UTC by gibson042 comment:4

Replying to [comment:2 gnarf]:

I actually like the idea of having a Vagrantfile available to spawn up an nginx that runs the same config as the builds.jenkins.jquery.com
I could setup a dns entry for something like vagrant.jquery.com rather than needing anyone to ever edit their hosts file.

Replying to [comment:3 eric@…]:

I'm also considering packaging a Vagrant box with PHP/Nginx already installed _and_ configured. This would allow the bundled configuration to ship with nothing more than a Vagrantfile (much cleaner in the repository) and developers could continue to use either their *AMP install or Mongoose instead of Vagrant without much trouble.

Okay, that all sounds ''really'' nice. I'm sold.

Changed October 28, 2013 03:06PM UTC by gnarf comment:5

Yeah - If we can get the .box setup with nginx/etc without having to download it post spin-up that saves a big portion of the problem.

We can host the source box on the infra dropbox also and keep it up to day.

Changed January 23, 2014 04:51PM UTC by timmywil comment:6

component: unfiled → build
priority: undecided → high

Changed October 21, 2014 12:23AM UTC by m_gol comment:7

resolution: → migrated
status: open → closed

Migrated to https://github.com/jquery/jquery/issues/1755