Ticket #1392 (closed bug: invalid)
Gecko is gecko
| Reported by: | Jonno | Owned by: | |
|---|---|---|---|
| Priority: | minor | Milestone: | 1.2.1 |
| Component: | core | Version: | 1.2 |
| Keywords: | Cc: | ||
| Blocking: | Blocked by: |
Description
Basicaly, detecting "Mozilla" is not very smart (as many, but not all, non-Mozilla browsers include Mozilla in their user agents). The only safe way I know about to reliably detect a Mozilla based browser is to look for Gecko/YYYYMMDD in the user agent (other browser may include "like Gecko", but none other include the gecko build date).
More browsers than Opera might masquerade as MSIE. The only way to reliably detect for MSIE is to use Conditional Compilation of JavaScript in IE.
The attached patch fixes these issues as well as adds support for khtml (very similar to WebKit).
Attachments
-
geckoisgecko.patch
(3.6 KB) -
added by Jonno 6 years ago.
Change History
comment:1 Changed 6 years ago by john
- Status changed from new to closed
- Version changed from 1.1.3 to 1.2
- Resolution set to invalid
- Milestone changed from 1.1.4 to 1.2.1
Our current implementation works for all browsers that we support - if a user is spoofing their useragent, then they're obviously asking for that browser's specific implementation of functionality. We should not try to circumvent that.
Please follow the bug reporting guidlines and use jsFiddle when providing test cases and demonstrations instead of pasting the code in the ticket.