Side navigation
#13523 closed bug (invalid)
Opened February 26, 2013 10:04PM UTC
Closed March 13, 2013 08:59AM UTC
Identity comparator in isWindow should be strict equality operator
| Reported by: | carson@carsonkahn.com | Owned by: | carson@carsonkahn.com |
|---|---|---|---|
| Priority: | undecided | Milestone: | None |
| Component: | unfiled | Version: | 1.9.1 |
| Keywords: | Cc: | ||
| Blocked by: | Blocking: |
Description
Identity comparator in isWindow should be strict equality operator
BUG: In the $.isWindow check, the righthand expression in the return conditional should probably use obj === obj.window (currently uses ''=='').
REASON: The ''seq'' is more accurate, faster, and safer in this case.
Attachments (0)
Change History (3)
Changed February 26, 2013 10:14PM UTC by comment:1
| owner: | → carson@carsonkahn.com |
|---|---|
| status: | new → pending |
Changed February 26, 2013 10:27PM UTC by comment:2
Seems like it would on oldIE, but Carson sounded pretty certain so let's wait for a test case.
Changed March 13, 2013 08:59AM UTC by comment:3
| resolution: | → invalid |
|---|---|
| status: | pending → closed |
Because we get so many tickets, we often need to return them to the initial reporter for more information. If that person does not reply within 14 days, the ticket will automatically be closed, and that has happened in this case. If you still are interested in pursuing this issue, feel free to add a comment with the requested information and we will be happy to reopen the ticket if it is still valid. Thanks!
Does that change break this: https://github.com/jquery/jquery/commit/0fcfac7568823a4eec4e5dd7b9bf527a8ec04f5c ?