Bug Tracker

#13246 closed bug (notabug)

Opened January 17, 2013 11:17AM UTC

Closed January 17, 2013 02:39PM UTC

Last modified January 17, 2013 03:13PM UTC

bad working filter

Reported by: punkundead@gmail.com Owned by:
Priority: undecided Milestone: None
Component: unfiled Version: 1.9.0
Keywords: Cc:
Blocked by: Blocking:
Description
jQuery('a')
.filter('.colorbox') //empty collection
.colorbox();

create incorrect widget

but

jQuery('a.colorbox') //empty collection
.colorbox();

nothing create

https://github.com/jackmoore/colorbox/issues/303

Attachments (0)
Change History (3)

Changed January 17, 2013 02:39PM UTC by dmethvin comment:1

resolution: → notabug
status: new → closed

Can you provide a test case on jsfiddle.net?

Changed January 17, 2013 03:00PM UTC by punkundead@gmail.com comment:2

ok

http://jsfiddle.net/uBvMU/1/

Changed January 17, 2013 03:13PM UTC by dmethvin comment:3

I suspect this line in the plugin is causing the problem:

if ($this.selector) { // if a selector was given and it didn't match any elements, go ahead and exit.

The .selector property was never documented or public, and the logic there may be making incorrect assumptions. There are also several uses of undocumented jQuery.support properties that may have changed, it's trying to divine whether the browser is IE or not.

The plugin author will need to revise the plugin for it to work with 1.9.