Bug Tracker

#13154 closed bug (notabug)

Opened January 04, 2013 05:18PM UTC

Closed January 04, 2013 08:10PM UTC

Remove $.sub leftovers

Reported by: anonymous Owned by: anonymous
Priority: undecided Milestone: None
Component: unfiled Version: git
Keywords: Cc:
Blocked by: Blocking:
Description

There are places in the source code where this.constructor is used. Now that $.sub is removed, these can safely be set back to jQuery. The call in .end also doesn't need null.

Attachments (0)
Change History (3)

Changed January 04, 2013 08:00PM UTC by rwaldron comment:1

owner: → anonymous
status: new → pending

I suspect this would break the jQuery migration plugin... https://github.com/jquery/jquery-migrate

Changed January 04, 2013 08:09PM UTC by dmethvin comment:2

Right, we need to be able to add it back via jquery-migrate so this change shouldn't be made.

BTW, right now the PhantomJS unit tests in the plugin are broken when tested with 2.0 because of the .apply(this, NodeList) changes which PhantomJS doesn't like. It seems to pass in real browsers though.

Changed January 04, 2013 08:10PM UTC by dmethvin comment:3

resolution: → notabug
status: pending → closed