Bug Tracker

Ticket #12886 (closed feature: fixed)

Opened 2 years ago

Last modified 15 months ago

Add source map support for build

Reported by: dmethvin Owned by:
Priority: low Milestone: 1.9
Component: build Version: 1.8.2
Keywords: Cc: paul.irish
Blocking: Blocked by:

Description

Create source map during the build process to make debugging the .min versions easire. Need Uglify2 for that.

Change History

comment:1 Changed 2 years ago by dmethvin

  • Priority changed from undecided to low
  • Status changed from new to open
  • Component changed from unfiled to build
  • Milestone changed from None to 1.9

comment:2 Changed 2 years ago by paul.irish

  • Cc paul.irish added

comment:3 Changed 2 years ago by dmethvin

  • Milestone changed from 1.9 to 2.0

comment:4 Changed 2 years ago by dmethvin

  • Status changed from open to closed
  • Resolution set to fixed
  • Milestone changed from 2.0 to 1.9

Landed at  https://github.com/jquery/jquery/commit/b20f536748300d5aef31ad68cc5adff849a1ee13

Releases at code.jquery.com will have associated maps, and maps will be included in the packages released to other CDNs:

jquery-X.Y.Z.js
jquery-X.Y.Z.min.js
jquery-X.Y.Z.min.map

NOTE: Renaming the uncompressed jquery-X.Y.Z.js file requires an edit to the jquery-X.Y.Z.min.map file to reference its new name or location.

comment:5 Changed 23 months ago by ryanseddon

You may be aware but the current rc1 release of 1.9 tries to request code.jquery.com/dist/jquery.min.map in chrome dev tools which 404s.

Manually requesting  http://code.jquery.com/jquery-1.9.0rc1.min.map works but the comment being generated by the build is wrong.

comment:6 Changed 23 months ago by dmethvin

  • Status changed from closed to reopened
  • Resolution fixed deleted

Thanks! Yes, the build process fixed the map file but I missed the comment.

comment:7 Changed 23 months ago by dmethvin

  • Status changed from reopened to closed
  • Resolution set to fixed

Lazy bots.

Closed via  https://github.com/jquery/jquery/commit/e348b4060848b46a6c4376661c093e0f0a3ef9e7 (1.9) and  https://github.com/jquery/jquery/commit/2ff2d1d3dcd99f7bd45fa312ba91bb1248cb6d55 (2.0)

I am seeing inconsistent behavior in Chrome 23 Windows but think it's Chrome and not the map file.

comment:8 Changed 16 months ago by ferndriger.business@…

Chrome Version 29 tries to load .../jquery.min.map 404 (Not Found)

comment:9 Changed 16 months ago by radu19@…

I confirm that Chrome version 29 tries to load /jquery.min.map and fails. Also Chrome Canary...

comment:10 follow-up: ↓ 13 Changed 16 months ago by dmethvin

The last two posters. What version of jQuery are you using? Did you rename the files?

comment:11 Changed 16 months ago by Andrew

We see the same problem - request's for jquery.min.map (which 404) from: Chrome 28.0.1500.95 (up to date as of today) and jquery-2.0.3.min.js (downloaded fresh this morning - and not renamed or fiddled with in any way. OSX Lion 10.7.5 (although hopefully that's irrelevant)

Interestingly, it requests the missing file at the same path as jquery. Ie, jquery is referenced at /somefolder/jquery-2.0.3.min.js and the missing file is requested at: /somefolder/jquery-2.0.3.min.map

This only happens if we have the chrome dev-tools open. (checked using an http debugger).

comment:12 Changed 16 months ago by dmethvin

@Andrew, if you have "use sourcemaps" enabled in dev tools and did not copy the map file to the same location with the same name, then the map file is indeed missing.

comment:13 in reply to: ↑ 10 Changed 15 months ago by anonymous

Replying to dmethvin:

The last two posters. What version of jQuery are you using? Did you rename the files?

Hi, I have same problem - Chrome 29 - using "jquery-1.9.1.min.js" - no renaming involved... Hope this helps.

Note: See TracTickets for help on using tickets.