Side navigation
#12741 closed bug (fixed)
Opened October 16, 2012 12:08PM UTC
Closed January 06, 2013 03:14PM UTC
inconsistent line endings in official jquery-1.8.2.js download
Reported by: | oberhamsi | Owned by: | |
---|---|---|---|
Priority: | high | Milestone: | 1.9 |
Component: | build | Version: | 1.8.2 |
Keywords: | needsreview | Cc: | |
Blocked by: | Blocking: |
Description
subversion was angy when I tried to add jquery. And to my surprise it was right: jquery-1.8.2.js download has inconsitent line ending.
it seems the sizzle lines are the offenders. before and after sizzle everything has clean "\\n". but from line 3668 on i see "\\r\\n".
I cloned sizzle from github and it doesn't have this problem. i did not try to build jquery to figure out at which steps the '/r' are added.
I expected all lines to end in "\\n".
simon@duchov:/tmp$ wget http://code.jquery.com/jquery-1.8.2.js simon@duchov:/tmp$ grep -n $'\\r' jquery-1.8.2.js | head 3668:/*! 3669: * Sizzle CSS Selector Engine 3670: * Copyright 2012 jQuery Foundation and other contributors 3671: * Released under the MIT license 3672: * http://sizzlejs.com/ 3673: */ 3674:(function( window, undefined ) { 3675: 3676:var cachedruns, 3677: assertGetIdNotName,
Attachments (0)
Change History (5)
Changed October 16, 2012 01:35PM UTC by comment:1
component: | unfiled → build |
---|---|
keywords: | → needsreview |
milestone: | None → 1.8.3 |
priority: | undecided → high |
status: | new → open |
Changed October 16, 2012 02:24PM UTC by comment:2
Most likely because it's using the native line endings for jQuery where I build and release in Windows, but the git line endings for the submodules which were built in Unix.
Changed November 11, 2012 08:31PM UTC by comment:3
milestone: | 1.8.3 → 1.9 |
---|
Changed January 06, 2013 03:14PM UTC by comment:5
resolution: | → fixed |
---|---|
status: | open → closed |
Fix #12471. Use consistent line endings in jquery.js
https://github.com/jquery/jquery/commit/b760d798d35d4c945c9c5240bb8cb4719330ad1f
This could be an issue with the build. Needs investigation.