Side navigation
#12076 closed bug (patchwelcome)
Opened July 13, 2012 02:48AM UTC
Closed September 17, 2012 04:00PM UTC
In IE8 and below, time elements in cloned table elements have incorrect tag structures
| Reported by: | Ian Yang <ian.html@gmail.com> | Owned by: | rwaldron |
|---|---|---|---|
| Priority: | high | Milestone: | None |
| Component: | manipulation | Version: | 1.7.2 |
| Keywords: | Cc: | ||
| Blocked by: | Blocking: |
Description
In IE8 and below, time elements in cloned table elements have incorrect tag structures like <:time>2012-07-12</:time>.
Attachments (0)
Change History (8)
Changed July 13, 2012 02:56AM UTC by comment:1
| component: | unfiled → manipulation |
|---|---|
| owner: | → rwaldron |
| priority: | undecided → high |
| status: | new → assigned |
Changed July 13, 2012 03:00AM UTC by comment:2
| priority: | high → low |
|---|---|
| resolution: | → invalid |
| status: | assigned → closed |
jQuery does not shim HTML5 elements, you MUST include html5shiv
Changed July 13, 2012 03:04AM UTC by comment:3
I did include html5shiv.
Changed July 13, 2012 04:03AM UTC by comment:4
| resolution: | invalid |
|---|---|
| status: | closed → reopened |
Forgive me - it's late, I'm tired and I missed that. Re-opening.
Changed July 13, 2012 04:06AM UTC by comment:5
| priority: | low → high |
|---|---|
| status: | reopened → assigned |
Changed July 13, 2012 04:11AM UTC by comment:6
When I remove the table from the equation, it works fine, but whenever the unknown element is the child of the element being cloned, the whole system breaks down. I'll look at this further tomorow.
Changed July 13, 2012 04:17AM UTC by comment:7
Thanks. Good night.
Changed September 17, 2012 04:00PM UTC by comment:8
| resolution: | → patchwelcome |
|---|---|
| status: | assigned → closed |
The only reasonable solution to solving this is to copy innerHTML from the source element into the clone element. Since we only want to do this when a non-native element (ie. HTML5 nodes are not native in oldIE) appears as a child of the element being cloned. To do this, we need to look at all of the children of the element being cloned and check if any have a nodeName that matches the known and supported HTML5 nodeNames. If any of those children have children themselves, then we need to traverse downward and run the same check on all of those children (and of course, so on down through all children). When the nest is only one or two branches deep, with a only a handful of children, this will work just fine. The problem comes when there are very deeply nested DOM trees with large children counts. In those cases, this approach becomes unrealistic.