Bug Tracker

Modify ↓

Ticket #11632 (closed bug: invalid)

Opened 13 months ago

Last modified 13 months ago

FUNCTION CREATESAFEFRAGMENT HAVE SOME REDUNDANT CODE

Reported by: snandy Owned by: snandy
Priority: low Milestone: None
Component: unfiled Version: 1.7.2
Keywords: Cc:
Blocking: Blocked by:

Description

Only document object has createElement method. so "if ( safeFrag.createElement )"in createSafeFragment is redundant.

Change History

comment:1 Changed 13 months ago by sindresorhus

  • Owner set to snandy
  • Priority changed from undecided to low
  • Status changed from new to pending

Can you link to some references? Line number?

There's probably a reason it's there. Try to remove it, run the testsuite in supported browsers, and report back if it still passes.

comment:2 Changed 13 months ago by rwaldron

  • Status changed from pending to closed
  • Resolution set to invalid

That's how we avoid the loop in modern browsers. In oldIE, there is a createElement method on DocumentFragment:  http://jsfiddle.net/rwaldron/ZGgGs/

comment:3 Changed 13 months ago by snandy

thanks!

Please follow the  bug reporting guidlines and use  jsFiddle when providing test cases and demonstrations instead of pasting the code in the ticket.

View ↑

Add a comment

Modify Ticket

Action
as closed
Author


E-mail address and user name can be saved in the Preferences.

Attachments ↑
 
Note: See TracTickets for help on using tickets.