Ticket #11164 (closed feature: wontfix)
document all support tests
| Reported by: | mikesherov | Owned by: | mikesherov |
|---|---|---|---|
| Priority: | low | Milestone: | 1.next |
| Component: | support | Version: | 1.7.1 |
| Keywords: | Cc: | paul.irish | |
| Blocking: | Blocked by: |
Description
Yes, we all love feature detection, but what about support tests? It's a good idea to know what browser(s) caused you to write the test in the first place in case we ever decide to drop support for that browser. It'd also be good to know if there was a publicly tracked bug report for the support test.
I'm going to go through each support test and figure out what browser it is written for, and see if there are any bug tracker tickets, and then document each one with a standard set of comments. I hope that at best, this exposes some archaic removable support tests, and at worst, prepares us for the next time we want to drop a browser.
Change History
comment:1 Changed 17 months ago by mikesherov
- Owner set to mikesherov
- Priority changed from undecided to low
- Status changed from new to assigned
- Component changed from unfiled to support
- Milestone changed from None to 1.8
comment:2 Changed 17 months ago by rwaldron
I think a lot of this can be found in test/unit/support.js right?
comment:3 Changed 17 months ago by timmywil
This should not be officially documented, but with comments in support.js, as rwaldron indicates.
comment:4 Changed 17 months ago by mikesherov
"I'm going to go through each support test and figure out what browser it is written for, and see if there are any bug tracker tickets, and then document each one with a standard set of comments."
Yes, documenting it in code :-)
comment:6 Changed 12 months ago by dmethvin
If we can have the test swarm data record which values there are for each feature detect, we could collect that and see whether any feature detects were true or false across all supported browsers. That would mean we could drop the feature detect (or that we had a bug, as unlikely as that might be).
Please follow the bug reporting guidlines and use jsFiddle when providing test cases and demonstrations instead of pasting the code in the ticket.