Bug Tracker

Ticket #11163 (closed bug: fixed)

Opened 3 years ago

Last modified 2 years ago

jQuery.support.checkClone always true

Reported by: markel Owned by:
Priority: low Milestone: 1.8
Component: support Version: 1.7.1
Keywords: Cc:
Blocking: Blocked by:

Description

For old webkit based browsers it shouldn't

Change History

comment:1 Changed 3 years ago by markel

comment:2 Changed 3 years ago by timmywil

  • Priority changed from undecided to low
  • Status changed from new to open
  • Component changed from unfiled to support

Keep in mind that support.checkClone is not only for old Webkit. It currently and should continue to be false for IE6/7. Does removing the second cloneNode call have any adverse effects for other browsers?

According to your pull, a name is needed on the input to trigger the bug in older versions of webkit? If so, please comment to that effect so it is not removed in the future. Also, the style for single arguments with quotes is

document.createElement("input");

comment:3 Changed 3 years ago by markel

Keep in mind that support.checkClone is not only for old Webkit. It currently and should continue to be false for IE6/7

IE6/7 problem is with defaultChecked attribute, if it set to true then cloned radio will be checked, and you already have fix for IE, which is not involve checkClone property. But because checkClone is false for IE6/7 you run some needless operations, that can be avoided.

Does removing the second cloneNode call have any adverse effects for other browsers?

I did not find any. But i'm concern about this ticket description -- http://bugs.jquery.com/ticket/5929 I have found problems only with radio input, not with checkbox input.

Btw link that i was mentioned in other ticket have illustrated some others bugs --  http://jsfiddle.net/fxT2r/. But i suppose its a very edge cases?

comment:4 Changed 2 years ago by mikesherov

Markel, this is fixed now, right?

comment:5 Changed 2 years ago by mikesherov

  • Status changed from open to closed
  • Resolution set to fixed
  • Milestone changed from None to 1.8

From what I can tell, this is fixed. Markel, if I'm wrong, let me know and I'll reopen.

Note: See TracTickets for help on using tickets.