Bug Tracker

Modify

Ticket #10947 (closed bug: invalid)

Opened 19 months ago

Last modified 19 months ago

Remove redundant return value in $.Callbacks

Reported by: dcherman Owned by:
Priority: undecided Milestone: None
Component: unfiled Version: git
Keywords: Cc:
Blocking: Blocked by:

Description

 https://github.com/jquery/jquery/blob/master/src/callbacks.js#L213-215

fireWith already returns this, so you can save a couple of bytes by changing fire to just return self.fireWith( this, arguments );

Change History

comment:1 Changed 19 months ago by dcherman

Ugh never mind, close this as invalid please.

Should have tested this locally first, it breaks the Deferred chainability tests.

comment:2 Changed 19 months ago by dmethvin

  • Status changed from new to closed
  • Resolution set to invalid

And that's why we test. :)

Please follow the  bug reporting guidlines and use  jsFiddle when providing test cases and demonstrations instead of pasting the code in the ticket.

View

Add a comment

Modify Ticket

Action
as closed
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.