Bug Tracker

#1084 closed bug (fixed)

Opened March 29, 2007 12:10PM UTC

Closed July 30, 2007 02:52AM UTC

Last modified October 14, 2008 10:33AM UTC

jQuery.find can't handle underscores in nodeNames

Reported by: tcooijmans Owned by: john
Priority: major Milestone: 1.1.4
Component: core Version: 1.1.3
Keywords: Cc:
Blocked by: Blocking:
Description

Due to a broken regular expression in jQuery.find, the find expression is parsed incorrectly. Nodes with underscores in their names won't be found (because jQuery will look only for the part before the first underscore).

It's just one character, but I'm attaching a diff anyway.

Attachments (1)
  • selector.js.diff (1.0 KB) - added by john March 29, 2007 06:07PM UTC.

    It's never just one character ;-) this patch makes sure that there's total coverage of the tag names and the ability to use both underscores and unicode.

Change History (7)

Changed April 03, 2007 10:49PM UTC by brandon comment:1

need: Commit → Test Case

Changed April 28, 2007 03:39PM UTC by john comment:2

resolution: → fixed
status: new → closed

Fixed in SVN rev [1810].

Changed May 13, 2007 05:35PM UTC by brandon comment:3

description: Due to a broken regular expression in jQuery.find, the find expression is parsed incorrectly. Nodes with underscores in their names won't be found (because jQuery will look only for the part before the first underscore).\ \ It's just one character, but I'm attaching a diff anyway. → Due to a broken regular expression in jQuery.find, the find expression is parsed incorrectly. Nodes with underscores in their names won't be found (because jQuery will look only for the part before the first underscore). \ \ It's just one character, but I'm attaching a diff anyway.
need: Test Case → Patch
resolution: fixed
status: closed → reopened

The test for this is failing in Opera.

Changed July 15, 2007 03:10PM UTC by john comment:4

milestone: 1.1.3 → 1.1.4
resolution: → fixed
status: reopened → closed
version: 1.1.2 → 1.1.3

This was resolved.

Changed July 30, 2007 02:29AM UTC by john comment:5

resolution: fixed
status: closed → reopened

Changed July 30, 2007 02:29AM UTC by john comment:6

owner: → john
status: reopened → new

Oops, still fails in the test suite.

Changed July 30, 2007 02:52AM UTC by john comment:7

resolution: → fixed
status: new → closed

Fixed in SVN rev [2522].