Side navigation
#10701 closed bug (fixed)
Opened November 07, 2011 12:59PM UTC
Closed November 07, 2011 04:08PM UTC
Problems with submit forms using submit function
| Reported by: | anonymous | Owned by: | dmethvin |
|---|---|---|---|
| Priority: | low | Milestone: | 1.7.1 |
| Component: | event | Version: | 1.7 |
| Keywords: | Cc: | ||
| Blocked by: | Blocking: |
Description
On 1.7 form is posting even if onsubmit returns false. In 1.6.4 everithing was working good.
You can test it here: http://jsfiddle.net/cxSmk/1/
When you click on "Submit" using 1.7 it will ask you to download bin file.
Firefox 7.0.1
Attachments (0)
Change History (4)
Changed November 07, 2011 02:34PM UTC by comment:1
| component: | unfiled → event |
|---|---|
| priority: | undecided → low |
| resolution: | → invalid |
| status: | new → closed |
Changed November 07, 2011 03:06PM UTC by comment:2
| resolution: | invalid |
|---|---|
| status: | closed → reopened |
Yeah it just needs an extra check in .trigger().
The reason this got through, however, is that we consider inline handlers a wontfix item and don't have any unit tests for them. I will fix it but also point out that inline handlers do not always work reliably in jQuery because they're not under our control.
Changed November 07, 2011 03:06PM UTC by comment:3
| milestone: | None → 1.7.1 |
|---|---|
| owner: | → dmethvin |
| status: | reopened → assigned |
"return false" only works if you use jQuery to bind the handlers.
http://jsfiddle.net/timmywil/cxSmk/3/