Bug Tracker

Modify

Ticket #10693 (closed enhancement: fixed)

Opened 2 years ago

Last modified 2 years ago

generalize the "test something in an iframe" code in unit tests

Reported by: mikesherov Owned by: mikesherov
Priority: low Milestone: 1.7.2
Component: build Version: 1.7
Keywords: Cc:
Blocking: Blocked by:

Description

there are 3 different pieces of code in 3 different unit test modules:

support.js: supportIFrameTest
selector.js: testIframe
offset.js: testoffset

testIframe and testOffset are almost exact duplicates. supportIFrameTest is close enough. I was about to start writing another one for a ticket I'm trying to fix in event.js, but perhaps it's time to DRY this code and move it into test/data/testinit.js ?

I'd be glad to take a stab at it. 1.8?

Change History

comment:1 Changed 2 years ago by dmethvin

  • Priority changed from undecided to low
  • Status changed from new to open
  • Component changed from unfiled to build
  • Milestone changed from None to 1.8

Sounds like a good idea!

comment:2 Changed 2 years ago by mikesherov

  • Owner set to mikesherov
  • Status changed from open to assigned

comment:3 Changed 2 years ago by mikesherov

  • Milestone changed from 1.8 to 1.7.2

comment:4 Changed 2 years ago by mikesherov

  • Status changed from assigned to closed
  • Resolution set to fixed

Please follow the  bug reporting guidlines and use  jsFiddle when providing test cases and demonstrations instead of pasting the code in the ticket.

View

Add a comment

Modify Ticket

Action
as closed
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.