Side navigation
#10693 closed enhancement (fixed)
Opened November 06, 2011 05:04AM UTC
Closed February 25, 2012 03:54PM UTC
Last modified March 14, 2012 07:51AM UTC
generalize the "test something in an iframe" code in unit tests
| Reported by: | mikesherov | Owned by: | mikesherov |
|---|---|---|---|
| Priority: | low | Milestone: | 1.7.2 |
| Component: | build | Version: | 1.7 |
| Keywords: | Cc: | ||
| Blocked by: | Blocking: |
Description
there are 3 different pieces of code in 3 different unit test modules:
support.js: supportIFrameTest selector.js: testIframe offset.js: testoffset
testIframe and testOffset are almost exact duplicates. supportIFrameTest is close enough. I was about to start writing another one for a ticket I'm trying to fix in event.js, but perhaps it's time to DRY this code and move it into test/data/testinit.js ?
I'd be glad to take a stab at it. 1.8?
Attachments (0)
Change History (4)
Changed November 06, 2011 01:52PM UTC by comment:1
| component: | unfiled → build |
|---|---|
| milestone: | None → 1.8 |
| priority: | undecided → low |
| status: | new → open |
Changed November 28, 2011 02:44AM UTC by comment:2
| owner: | → mikesherov |
|---|---|
| status: | open → assigned |
Changed February 23, 2012 08:55PM UTC by comment:3
| milestone: | 1.8 → 1.7.2 |
|---|
Changed February 25, 2012 03:54PM UTC by comment:4
| resolution: | → fixed |
|---|---|
| status: | assigned → closed |
Sounds like a good idea!