Test Support bug

[zhengzongyi@…]

hi , when i read the jQuery's code, in line 1286. the jQuery append firstChild of div that is either a table or textNode, not a checkbox. but test its checked property in line 1289.

thanks.

[dmethvin]

I think the code you are referring to is here in support.js:

input.setAttribute("checked", "checked");
div.appendChild( input );
fragment = document.createDocumentFragment();
fragment.appendChild( div.firstChild );

// WebKit doesn't clone checked state correctly in fragments
support.checkClone = fragment.cloneNode( true ).cloneNode( true ).lastChild.checked;

It looks correct to me; the fragment is being cloned and the only thing in the fragment is an input element. Can you provide more information, or better yet a test case that fails?

[anonymous]

sorry, i can't provide more information. i debug the code, the "fragment.lastChild" isn't a input, it is a textNode or table.

[dmethvin]

I agree, it seems like a bug. Thanks! I think the code should have appended div.lastChild which is an <input /> and not div.firstChild.

[dmethvin]

Fixed.  https://github.com/jquery/jquery/commit/09c089aac9236e9e1866d8daad2e3b61a57f7d4c

[anonymous]

I think this is fixed.