Side navigation
#10485 closed feature (wontfix)
Opened October 12, 2011 09:18PM UTC
Closed October 29, 2012 04:34PM UTC
use @hidden attribute to toggle visibility
| Reported by: | paul.irish | Owned by: | rwaldron |
|---|---|---|---|
| Priority: | low | Milestone: | 1.next |
| Component: | effects | Version: | git |
| Keywords: | 1.9-discuss | Cc: | |
| Blocked by: | Blocking: |
Description
(in supporting browsers)
That way we dont need to capture current display value, cache it, and restore it.
http://www.whatwg.org/specs/web-apps/current-work/multipage/editing.html#the-hidden-attribute
Implemented in FF, Chrome, Saf, and Opera: http://en.wikipedia.org/wiki/Comparison_of_layout_engines_(HTML5)#Global
Attachments (0)
Change History (14)
Changed October 12, 2011 11:58PM UTC by comment:1
| component: | unfiled → effects |
|---|---|
| milestone: | None → 1.next |
| owner: | → rwaldron |
| priority: | undecided → low |
| status: | new → assigned |
Changed November 16, 2011 02:38AM UTC by comment:2
Holy shit we need this. defaultDisplay() is a disaster.
Changed November 16, 2011 03:13AM UTC by comment:3
We've explored this before and it didn't seem to give us much. Unfortunately, we'll always need defaultDisplay and we'll always have to check, if for no other reason than user stylesheets can set display to none.
Changed November 16, 2011 04:33AM UTC by comment:4
Replying to [comment:2 mikesherov]:
Holy shit we need this. defaultDisplay() is a disaster.
Rude :P
Changed November 16, 2011 04:38AM UTC by comment:5
Also, defaultDisplay() doesn't have anything to do with determining if something is hidden or not displayed. It's purpose is to restore display to the correct value for a given node; regardless of what the user land code has done.
Changed July 14, 2012 02:23AM UTC by comment:6
| keywords: | → 1.9-discuss |
|---|
Changed September 09, 2012 01:11AM UTC by comment:7
| type: | enhancement → feature |
|---|
Bulk change from enhancement to feature.
Changed September 12, 2012 09:28AM UTC by comment:8
I want to implement this.
What’s the expected behavior? Should IE<10 use old way and browsers that support hidden just toggle hidden attr?
Changed September 12, 2012 12:03PM UTC by comment:9
I think that's part of the assignment. Also to determine whether this complicates our own internal checks to see if an element is hidden. If we end up having to create two completely different paths for hiding elements and need additional checks for hidden elements, the benefits would have to be really good.
Also just to clarify, the team may vote that a feature is worth investigating and even implementing, but determine that the final result isn't worth its code or complexity cost. The vote is not a commitment to land any particular code.
Changed September 24, 2012 05:02PM UTC by comment:10
-1, We'd need the old path, even in jQuery 2.0, since IE9 doesn't have @hidden. Can't imagine any perf benefit either.
Changed September 24, 2012 05:11PM UTC by comment:11
-1, Seems like unnecessary complexity until all browsers without this feature die. It's unfortunate.
Changed September 27, 2012 12:13PM UTC by comment:12
-1 for the foreseeable future.
Changed October 22, 2012 05:18PM UTC by comment:13
-1
Changed October 29, 2012 04:34PM UTC by comment:14
| resolution: | → wontfix |
|---|---|
| status: | assigned → closed |
No benefit until post-IE9 so let's not tackle any time soon.
This will be nice if it can stop the defaultDisplay() path