RemoveAttr should check if attribute exist (when it's possible) before remove it

[markel]

You already have similar behavior in removeClass method, without it you would got something like this --  http://jsperf.com/removeclass-without-check-for-classname-attr

Of course in removeClass that check needed for other reasons too, but in some cases it will improve performance for removeAttr.

Fast --  http://jsperf.com/removeattr-with-check-for-attr

Less faster --  http://jsperf.com/removeattr-with-check-for-attr-2

Equally fast or little bit slower --  http://jsperf.com/removeattr-with-check-for-attr-3

Pull request --  https://github.com/jquery/jquery/pull/538

[rwaldron]

Those perfs are bogus because the attribute doesn't exist after the first removal.

[markel]

First show how speed will improve without attributes, is no need for attribute to exist -- its hole point Second shows if one attribute exist and another is not, its add only one attribute every time Third remove and immediately add the same attribute, so every time its will remove attribute

Please look more closely, they not bogus.

[rwaldron]

I think you missed my edit...

Replying to markel:

First show how speed will improve without attributes, is no need for attribute to exist -- its hole point Second shows if one attribute exist and another is not, its add only one attribute every time Third remove and immediately add the same attribute, so every time its will remove attribute

Please look more closely, they not bogus.

[markel]

yeah, i see now

[dmethvin]

They both seem fast enough, but if you want to resurrect this submit let us know and we can discuss for 1.9.