Ticket #6006: 0001-added-object-as-event-fn-pairs-support-to-delegate.patch

---

File 0001-added-object-as-event-fn-pairs-support-to-delegate.patch, 5.0 KB (added by deadlyicon, February 02, 2010 01:28AM UTC)

patch on top of f9417b9da980f4fa79d03ba691d9f3442c5ab2f2

From d3825ef41b82a220e6d116c33514c8de03d81da2 Mon Sep 17 00:00:00 2001
From: Jared Grippe 
Date: Mon, 1 Feb 2010 16:05:56 -0800
Subject: [PATCH] added 'object as event/fn pairs' support to delegate

---
 src/event.js       |    7 ++++++-
 test/unit/event.js |   24 ++++++++++++++++++++++--
 2 files changed, 28 insertions(+), 3 deletions(-)

diff --git a/src/event.js b/src/event.js
index f6b3d31..c790c0f 100644
--- a/src/event.js
+++ b/src/event.js
@@ -868,7 +868,12 @@ jQuery.fn.extend({
 	},
 	
 	delegate: function( selector, types, data, fn ) {
-		return this.live( types, data, fn, selector );
+		if (jQuery.isPlainObject(types)){
+			for (var type in types) this.live( type, undefined, types[type], selector );
+		}else{
+			this.live( types, data, fn, selector );
+		}
+		return this;
 	},
 	
 	undelegate: function( selector, types, fn ) {
diff --git a/test/unit/event.js b/test/unit/event.js
index fbb156f..4ad1ff1 100644
--- a/test/unit/event.js
+++ b/test/unit/event.js
@@ -1126,14 +1126,18 @@ test("live with submit", function() {
 });
 
 test(".delegate()/.undelegate()", function() {
-	expect(65);
+	expect(81);
 
-	var submit = 0, div = 0, livea = 0, liveb = 0;
+	var submit = div = livea = liveb = livec = lived = 0;
 
 	jQuery("#body").delegate("div", "submit", function(){ submit++; return false; });
 	jQuery("#body").delegate("div", "click", function(){ div++; });
 	jQuery("#body").delegate("div#nothiddendiv", "click", function(){ livea++; });
 	jQuery("#body").delegate("div#nothiddendivchild", "click", function(){ liveb++; });
+	jQuery("#body").delegate("div#nothiddendivchild", {
+	  click: function(){ livec++; },
+	  'click hover': function(){ lived++; }
+	});
 
 	// Nothing should trigger on the body
 	jQuery("body").trigger("click");
@@ -1141,6 +1145,8 @@ test(".delegate()/.undelegate()", function() {
 	equals( div, 0, "Click on body" );
 	equals( livea, 0, "Click on body" );
 	equals( liveb, 0, "Click on body" );
+	equals( livec, 0, "Click on body" );
+	equals( lived, 0, "Click on body" );
 
 	// This should trigger two events
 	jQuery("div#nothiddendiv").trigger("click");
@@ -1148,6 +1154,8 @@ test(".delegate()/.undelegate()", function() {
 	equals( div, 1, "Click on div" );
 	equals( livea, 1, "Click on div" );
 	equals( liveb, 0, "Click on div" );
+	equals( livec, 0, "Click on body" );
+	equals( lived, 0, "Click on body" );
 
 	// This should trigger three events (w/ bubbling)
 	jQuery("div#nothiddendivchild").trigger("click");
@@ -1155,6 +1163,8 @@ test(".delegate()/.undelegate()", function() {
 	equals( div, 2, "Click on inner div" );
 	equals( livea, 2, "Click on inner div" );
 	equals( liveb, 1, "Click on inner div" );
+	equals( livec, 1, "Click on body" );
+	equals( lived, 1, "Click on body" );
 
 	// This should trigger one submit
 	jQuery("div#nothiddendivchild").trigger("submit");
@@ -1162,6 +1172,8 @@ test(".delegate()/.undelegate()", function() {
 	equals( div, 2, "Submit on div" );
 	equals( livea, 2, "Submit on div" );
 	equals( liveb, 1, "Submit on div" );
+	equals( livec, 1, "Click on body" );
+	equals( lived, 1, "Click on body" );
 
 	// Make sure no other events were removed in the process
 	jQuery("div#nothiddendivchild").trigger("click");
@@ -1169,6 +1181,8 @@ test(".delegate()/.undelegate()", function() {
 	equals( div, 3, "undelegate Click on inner div" );
 	equals( livea, 3, "undelegate Click on inner div" );
 	equals( liveb, 2, "undelegate Click on inner div" );
+	equals( livec, 2, "undelegate Click on inner div" );
+	equals( lived, 2, "undelegate Click on inner div" );
 
 	// Now make sure that the removal works
 	jQuery("#body").undelegate("div#nothiddendivchild", "click");
@@ -1177,6 +1191,8 @@ test(".delegate()/.undelegate()", function() {
 	equals( div, 4, "undelegate Click on inner div" );
 	equals( livea, 4, "undelegate Click on inner div" );
 	equals( liveb, 2, "undelegate Click on inner div" );
+	equals( livec, 2, "undelegate Click on inner div" );
+	equals( lived, 2, "undelegate Click on inner div" );
 
 	// Make sure that the click wasn't removed too early
 	jQuery("div#nothiddendiv").trigger("click");
@@ -1184,6 +1200,8 @@ test(".delegate()/.undelegate()", function() {
 	equals( div, 5, "undelegate Click on inner div" );
 	equals( livea, 5, "undelegate Click on inner div" );
 	equals( liveb, 2, "undelegate Click on inner div" );
+	equals( livec, 2, "undelegate Click on inner div" );
+	equals( lived, 2, "undelegate Click on inner div" );
 
 	// Make sure that stopPropgation doesn't stop live events
 	jQuery("#body").delegate("div#nothiddendivchild", "click", function(e){ liveb++; e.stopPropagation(); });
@@ -1192,6 +1210,8 @@ test(".delegate()/.undelegate()", function() {
 	equals( div, 6, "stopPropagation Click on inner div" );
 	equals( livea, 6, "stopPropagation Click on inner div" );
 	equals( liveb, 3, "stopPropagation Click on inner div" );
+	equals( livec, 2, "stopPropagation Click on inner div" );
+	equals( lived, 2, "stopPropagation Click on inner div" );
 
 	// Make sure click events only fire with primary click
 	var event = jQuery.Event("click");
-- 
1.6.5.2

Download in other formats:

Original Format